Skip to content

[helm] Add PDB and update label patterns #463

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[helm] Add PDB and update label patterns #463

merged 1 commit into from
Jul 12, 2021

Conversation

stevehipwell
Copy link
Contributor

Fixes aws/eks-charts#553

Description of changes:

  • Add PodDisruptionBudget when using enableSqsTerminationDraining with more than 1 replica
  • Add aws-node-termination-handler.selectorLabels template
  • Refactor selector label patterns to use aws-node-termination-handler.selectorLabels
  • Refactor labels to use the nindent idiomatic pattern

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stevehipwell
Copy link
Contributor Author

/assign @bwagner5

This was referenced Jul 5, 2021
Closed
Open
bwagner5
bwagner5 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@bwagner5 bwagner5 merged commit 5721fba into aws:main Jul 12, 2021
@stevehipwell stevehipwell deleted the add-pdb branch July 13, 2021 07:59
@ec2-bot ec2-bot mentioned this pull request Jul 28, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-node-termination-handler] No PDB
2 participants
@stevehipwell @bwagner5