Skip to content

chore(README): add hint about EKS managed node groups #664

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 28, 2022
Merged

chore(README): add hint about EKS managed node groups #664

merged 1 commit into from
Jul 28, 2022

Conversation

m00lecule
Copy link
Contributor

@m00lecule m00lecule commented Jul 28, 2022

Issue:

The Investigation if NTH is mandatory on EKS managed node groups took me few days. README.md is missing when it's recommended to deploy NTH - according to issue, it's pointless to deploy it on managed node groups.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@m00lecule m00lecule requested a review from a team as a code owner July 28, 2022 13:00
@m00lecule
Copy link
Contributor Author

I would kindly ask for a review @bwagner5

@CodyPubNub
Copy link

@bwagner5 hello 👋 I'd like to report that this hint is invalid. We use EKS Managed Node Groups and we absolutely require the NTH to be installed to handle AWS maintenance events. Our Managed Nodes are not automatically drained in response to degraded AWS maintenance events or scheduled reboots without the NTH. I'd suggest removing this Hint as it is invalid and misleading.

@bwagner5
Copy link
Contributor

@bwagner5 hello 👋 I'd like to report that this hint is invalid. We use EKS Managed Node Groups and we absolutely require the NTH to be installed to handle AWS maintenance events. Our Managed Nodes are not automatically drained in response to degraded AWS maintenance events or scheduled reboots without the NTH. I'd suggest removing this Hint as it is invalid and misleading.

ASG handles scheduled maintenance events for you on the backend. You should get a terminate lifecycle hook when a scheduled maintenance event is detected for an instance in the asg.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants