Skip to content

build: fix building without external dependencies #1859

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brgl
Copy link

@brgl brgl commented Feb 7, 2022

Issue #, if available:

Configuration fails with -DBUILD_DEPS=OFF because the cmake file containing the AwsFindPackage() macro is located in one of the submodules.

Description of changes:

Pull the relevant file into the main git repo to fix it.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Tests not applicable, patch affects the build system.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Configuration fails with -DBUILD_DEPS=OFF because the cmake file
containing the AwsFindPackage() macro is located in one of the submodules.
Pull it into the main git repo to fix it.
@jmklix
Copy link
Member

jmklix commented Jan 27, 2023

#1888

@jmklix jmklix added the needs-review This issue or pull request needs review from a core team member. label Jan 27, 2023
@jmklix jmklix added Cmake Cmake related submissions and removed needs-review This issue or pull request needs review from a core team member. labels Dec 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Cmake Cmake related submissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants