Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix ANDROID_BUILD_OPENSSL cmake option #3023

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix ANDROID_BUILD_OPENSSL cmake option #3023

merged 1 commit into from
Jul 2, 2024

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jul 1, 2024

Issue #, if available:

issues/3014

Description of changes:

We have a cmake arg ANDROID_BUILD_OPENSSL that builds openssl with the NDK if specified by a user. That was broken during our aws-c-cal migration as we treated openssl as "completely removed". this adds back logic to find and link the built openssl if specifed.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review July 2, 2024 13:55
@sbiscigl sbiscigl merged commit a95671d into main Jul 2, 2024
4 checks passed
@sbiscigl sbiscigl deleted the fix-android branch July 2, 2024 13:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants