Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix go1.19 vet failures #1779

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Fix go1.19 vet failures #1779

merged 1 commit into from
Jul 30, 2022

Conversation

skmcgrail
Copy link
Member

Fixes Go 1.19 vet failures due to the following:

The vet checker “errorsas” now reports when errors.As is called with a second argument of type *error, a common mistake.

@skmcgrail skmcgrail requested review from Purnaak and RanVaknin July 29, 2022 21:42
@Purnaak Purnaak closed this Jul 29, 2022
@Purnaak Purnaak reopened this Jul 29, 2022
Purnaak
Purnaak approved these changes Jul 30, 2022
View reviewed changes
Copy link

@Purnaak Purnaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@skmcgrail skmcgrail merged commit cb92592 into aws:main Jul 30, 2022
@skmcgrail skmcgrail deleted the go119 branch July 30, 2022 00:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Purnaak Purnaak Purnaak approved these changes

@RanVaknin RanVaknin Awaiting requested review from RanVaknin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skmcgrail @Purnaak