Use request body error message for unknown errors missing a message header #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar-b
commented
Feb 27, 2023
Comment on lines
+60
to
+62
| if len(code) == 0 { | ||
| code = jsonErr.Code | ||
| } |
There was a problem hiding this comment.
This condition was added to preserve backward compatibility and prevent the code from being overwritten if the code header was present.
There was a problem hiding this comment.
Agreed, this is also in line with both the smithy docs on restjson error type as well as a change we recently made in this area in go v2.
lucix-aws
approved these changes
Feb 28, 2023
lucix-aws
approved these changes
Feb 28, 2023
|
@lucix-aws - Thanks for the review! Is there anything else required for this to be merged? |
|
@jar-b Sorry for the delayed response - I'm picking this back up this week. It should be good to merge after CI passes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4733
This fix will handle cases when an unknown error response includes a code header, but not a message header. Rather than returning an empty message (the current behavior) the message parsed from the JSON body is returned.
Here is a trivial example of a lambda
ValidationExceptionbefore and after the change:Before:
After:
Also adds a pair of unit tests to cover "unknown" response cases with partial headers (ie. code without message and vice-versa):