Skip to content

Added recipe for adding comments for unsupported transforms #6033

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 15, 2025
Merged

Added recipe for adding comments for unsupported transforms #6033

merged 14 commits into from
Apr 15, 2025

Conversation

Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Apr 14, 2025 •
edited
Loading

Motivation and Context

We will not be able to support some of the v1 method and class in the migration tool. For these method we will add comments in the migrated code for users to manually migrate them.

Modifications

Added a recipe to add comments before migration tool unsupported method and class

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner April 14, 2025 18:20
zoewangg
zoewangg reviewed Apr 14, 2025
View reviewed changes
v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
removeV1S3ModelImport("CannedAccessControlList");
maybeAddV2CannedAclImport(method.getArguments(), isSetObjectAcl, isSetBucketAcl);

// TODO: add the developer guide link in the comments once the doc is published.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-s3.html?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be confusing since the developer guide is not published yet?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Fred1155 Fred1155 added this pull request to the merge queue Apr 15, 2025
@Fred1155 Fred1155 requested a review from zoewangg April 15, 2025 18:16
Merged via the queue into master with commit d1f1bb4 Apr 15, 2025
32 of 35 checks passed
@Fred1155 Fred1155 deleted the feature/master/migration-tool-comments-for-unsupported-transforms branch April 15, 2025 19:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

@davidh44 davidh44 davidh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fred1155 @zoewangg @davidh44