Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix typings for credentials provider chain #3510

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix typings for credentials provider chain #3510

merged 1 commit into from
Oct 29, 2020

Conversation

workeitel
Copy link
Contributor

Credentials[]|providers[] means either an array with Credentials or
an array with providers. But in reality it's a array with both.

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • non-code related change (markdown/git settings etc)

@workeitel
Fix typings for credentials provider chain
cc626d8 
`Credentials[]|providers[]` means either an array with `Credentials` or
an array with `providers`. But in reality it's a array with both.
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: cc626d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ajredniwja ajredniwja merged commit 3ede892 into aws:master Oct 29, 2020
@ajredniwja
Copy link
Contributor

Thank you for the contribution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ajredniwja ajredniwja ajredniwja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@workeitel @aws-sdk-js-automation @ajredniwja