dev: Add dependency diagram utility #4234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Jan 5, 2024
justinmk3
reviewed
Jan 5, 2024
docs/browser.md
Outdated
|
|
||
| ### How to use | ||
|
|
||
| 0. Ensure you have run `npm install --save-dev` |
There was a problem hiding this comment.
why is --save-dev needed? npm install should install dev deps by default
Since none of our modules are importing dependency-cruiser, can we change this instruction to:
npm install dependency-cruiser
Then our package-lock.json won't have the extra deps, and we won't need to maintain that dep.
nkomonen-amazon
force-pushed
the
depCruiser
branch
from
81a091e to
ab1e187
Compare
Adding in this dependency diagram generating utility for toolkit Browser work since we can have transitive dependencies which break the toolkit from running in the Browser. This will help us to find dependencies more easily instead of manually searching. Signed-off-by: nkomonen <nkomonen@amazon.com>
nkomonen-amazon
force-pushed
the
depCruiser
branch
from
ab1e187 to
86a54a0
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in this dependency diagram generating utility for toolkit Browser work since we can have transitive dependencies which break the toolkit from running in the Browser.
See the
browser.mdguide for more details hereThis will help us to find dependencies more easily instead of manually searching.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.