Recorder.configure: don't overwrite plugins unless specified #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With most options, Recorder.configure() doesn't touch the value if corresponding option is not passed.
But with `plugins` option behaviour is different: it is updated every time you call `configure`.
So this code won't work correctly:
xray_recorder.configure(plugins=('EC2Plugin', 'ECS'))
...
xray_recorder.configure(context=MyContext()) # this resets plugins
This patch will fix that behaviour: now in order to explicitly reset plugins, you will need to pass an empty tuple to `configure`;
if `plugins is None` then plugin list won't be changed.
|
What do you think of doing this: if plugins:
plugin_modules = get_plugin_modules(plugins)
for module in plugin_modules:
module.initialize()
self._plugins = plugin_modules |
|
This approach makes it impossible to remove previously added plugins. |
|
I.e. it will only change plugins list if at least one plugin is specified, with no option to pass empty list (which will be just ignored). Hence I added "is None" check. |
|
OK make sense. |
|
Could you also add a line on |
|
Done. Shall I squash it to the previous commit? |
haotianw465
approved these changes
Mar 19, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With most options, Recorder.configure() doesn't touch the value if corresponding option is not passed.
But with
pluginsoption behaviour is different: it is updated every time you callconfigure.So this code won't work correctly:
This patch will fix that behaviour: now in order to explicitly reset plugins, you will need to pass an empty tuple to
configure;if
plugins is Nonethen plugin list won't be changed.