Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix context menu styles #600

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix context menu styles #600

merged 2 commits into from
Sep 9, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Sep 9, 2024 •
edited
Loading

Description

The context menu was broken because the style name list-item collides with a Tailwind class called list-item. I renamed the existing list-item classes to avoid the collision.

Validation

CleanShot 2024-09-09 at 12 10 34@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review September 9, 2024 17:15
@kmcginnes kmcginnes merged commit 032cfd3 into aws:main Sep 9, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-context-menu branch September 9, 2024 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michaelnchin michaelnchin michaelnchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Right click menu is misaligned
2 participants
@kmcginnes @michaelnchin