Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve logging #604

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Improve logging #604

merged 8 commits into from
Sep 11, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Sep 11, 2024

Description

  • Log out requests with status 300 - 400
  • Format request log statements better
  • Use response "finish" event to capture request log which is more consistent
  • Call JSON.parse() with remote logger since it uses JSON.stringify() on the client end
    • Removes the extra double quotes in the log statements
  • Send schema sync log messages to the server
  • Add schema sync log messages to openCypher (already existed on Gremlin and SPARQL)
  • Add summary log messages with counts after schema sync

Validation

  • Tested request error handling by sending bad query
  • Tested schema sync with each query language

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review September 11, 2024 20:57
@kmcginnes kmcginnes marked this pull request as draft September 11, 2024 20:57
@kmcginnes kmcginnes marked this pull request as ready for review September 11, 2024 20:59
@kmcginnes kmcginnes merged commit 997f20d into aws:main Sep 11, 2024
1 check passed
@kmcginnes kmcginnes deleted the log-status-300-to-400 branch September 11, 2024 22:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Improve logging
2 participants