chore: update golangci 36 (#6936)

.golangci.yaml

@@ -4,19 +4,12 @@ run:
 
   timeout: 5m
 
-  skip-dirs:
-    - tools
-    - website
-    - hack
-    - charts
-    - designs
-
 linters:
   enable:
     - asciicheck
     - bidichk
     - errorlint
-    - exportloopref
+    - copyloopvar
     - gosec
     - revive
     - stylecheck
@@ -36,7 +29,7 @@ linters-settings:
   gocyclo:
     min-complexity: 11
   govet:
-    check-shadowing: true
+    shadow: true
   revive:
     rules:
     - name: dot-imports
@@ -66,6 +59,12 @@ linters-settings:
 issues:
   fix: true
   exclude: ['declaration of "(err|ctx)" shadows declaration at']
+  exclude-dirs:
+  - tools
+  - website
+  - hack
+  - charts
+  - designs
   exclude-rules:
   - linters:
     - goheader

pkg/providers/instancetype/suite_test.go

@@ -2323,7 +2323,6 @@ func generateSpot#(cp *cloudprovider.CloudProvider, nodePool *corev1beta1.
 			}
 		}
 		for _, o := range instanceType.Offerings {
-			o := o
 			if o.CapacityType != corev1beta1.CapacityTypeSpot {
 				continue
 			}

test/pkg/environment/common/monitor.go

@@ -133,7 +133,6 @@ func (m *Monitor) DeletedNodes() []*v1.Node {
 func (m *Monitor) PendingPods(selector labels.Selector) []*v1.Pod {
 	var pods []*v1.Pod
 	for _, pod := range m.poll().pods.Items {
-		pod := pod
 		if pod.Status.Phase != v1.PodPending {
 			continue
 		}
@@ -152,7 +151,6 @@ func (m *Monitor) PendingPodsCount(selector labels.Selector) int {
 func (m *Monitor) RunningPods(selector labels.Selector) []*v1.Pod {
 	var pods []*v1.Pod
 	for _, pod := range m.poll().pods.Items {
-		pod := pod
 		if pod.Status.Phase != v1.PodRunning {
 			continue
 		}