Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: consume log path values #6875

Merged
merged 6 commits into from
Aug 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
respond to pr comments
  • Loading branch information
rschalo committed Aug 26, 2024
commit ffc94045838a6e03508533736cd858dfc73b89ae
14 changes: 0 additions & 14 deletions charts/karpenter/templates/_helpers.tpl
Original file line number Diff line number Diff line change
@@ -140,17 +140,3 @@ This works because Helm treats dictionaries as mutable objects and allows passin
{{- include "karpenter.patchLabelSelector" (merge (dict "_target" $constraint) $) }}
{{- end }}
{{- end }}

{{/*
Flatten the stdout logging outputs from args provided
*/}}
{{- define "karpenter.outputPathsList" -}}
{{ join "," .Values.logOutputPaths }}
{{- end -}}

{{/*
Flatten the stderr logging outputs from args provided
*/}}
{{- define "karpenter.errorOutputPathsList" -}}
{{ join "," .Values.logErrorOutputPaths }}
{{- end -}}
8 changes: 6 additions & 2 deletions charts/karpenter/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -88,10 +88,14 @@ spec:
- name: LOG_LEVEL
value: "{{ . }}"
{{- end }}
{{- with .Values.logOutputPaths }}
- name: LOG_OUTPUT_PATHS
value: {{ include "karpenter.outputPathsList" . }}
value: "{{ join "," . }}"
{{- end }}
{{- with .Values.logErrorOutputPaths }}
- name: LOG_ERROR_OUTPUT_PATHS
value: {{ include "karpenter.errorOutputPathsList" . }}
value: "{{ join "," . }}"
{{- end }}
- name: METRICS_PORT
value: "{{ .Values.controller.metrics.port }}"
- name: HEALTH_PROBE_PORT
Loading