Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Drop knative imports #6892

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: Drop knative imports #6892

merged 1 commit into from
Aug 28, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
This PR drops knative imports and replaces any usage with alternatives.

How was this change tested?
manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner August 28, 2024 20:53
@jigisha620 jigisha620 requested a review from rschalo August 28, 2024 20:53
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 50e2557
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66cfa14ad6d97e0008ab9159

@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10605206052

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.04%

Totals Coverage Status
Change from base Build 10603991235: 0.02%
Covered Lines: 5513
Relevant Lines: 6639

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Aug 28, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

go.mod Outdated Show resolved Hide resolved
@jigisha620 jigisha620 merged commit 2951c9f into aws:main Aug 28, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants