Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: enable webhooks by default #6900

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Aug 30, 2024

Fixes #N/A

Description
Fixes an issue where k8s expects a conversion webhook is enabled (but it isn't) due to applying CRDs from the repo but the webhook.

How was this change tested?
Make presubmit.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner August 30, 2024 21:08
@rschalo rschalo requested a review from jigisha620 August 30, 2024 21:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10639178061

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.143%

Totals Coverage Status
Change from base Build 10517048870: 0.01%
Covered Lines: 5842
Relevant Lines: 7476

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit ba94cd1 into aws:release-v0.37.x Aug 31, 2024
14 checks passed
@rschalo rschalo deleted the enable-webhook-by-default branch August 31, 2024 02:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants