Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Update liniting for release-v0.34.x #6930

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Sep 5, 2024

Fixes #N/A

Description

  • Update liniting for v0.34.x

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Sep 5, 2024

Pull Request Test Coverage Report for Build 10725167571

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 77.333%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.37%
Totals Coverage Status
Change from base Build 10641607894: -0.005%
Covered Lines: 5394
Relevant Lines: 6975

💛 - Coveralls

@engedaam engedaam force-pushed the fix-liniting-34 branch 8 times, most recently from 1c35a7a to de73ae9 Compare September 5, 2024 05:17
hack/docgen.sh Outdated Show resolved Hide resolved
rschalo
rschalo previously approved these changes Sep 5, 2024
@rschalo rschalo self-requested a review September 5, 2024 17:20
@rschalo rschalo marked this pull request as ready for review September 5, 2024 18:05
@rschalo rschalo requested a review from a team as a code owner September 5, 2024 18:05
@rschalo rschalo merged commit e35e48d into aws:release-v0.34.x Sep 5, 2024
12 checks passed
@engedaam engedaam deleted the fix-liniting-34 branch October 30, 2024 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants