Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Fix interruption testing to check node deletion #7009

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This change ensures that we check the deletion timestamp of the node rather than waiting for the node to be gone within a 2m timeframe. This can flake often now due to the change that we made in kubernetes-sigs/karpenter#1195

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 13, 2024 08:28
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9764556
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66e3faa75e47c10009291c95

@coveralls
Copy link

coveralls commented Sep 13, 2024

Pull Request Test Coverage Report for Build 10845942443

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.04%

Totals Coverage Status
Change from base Build 10842727395: 0.02%
Covered Lines: 5513
Relevant Lines: 6639

💛 - Coveralls

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jonathan-innis jonathan-innis force-pushed the fix-interruption-testing branch from 6b440e5 to 9764556 Compare September 13, 2024 08:41
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-976455695248c7b6370c80a6f74c652a1e0ead13.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-976455695248c7b6370c80a6f74c652a1e0ead13" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis enabled auto-merge (squash) September 13, 2024 23:10
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit d07582b into aws:main Sep 13, 2024
29 of 31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants