Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Fix missed instance type cache assignment #7066

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Fix missed instanceTypeCache assignment in test.Environment

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 25, 2024 07:59
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 25, 2024 07:59
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit fafcfde
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f3c2ee4fce620008fe92f3
😎 Deploy Preview https://deploy-preview-7066--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11028795321

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.008%

Totals Coverage Status
Change from base Build 11025546705: 0.02%
Covered Lines: 5520
Relevant Lines: 6650

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 99cff6d into aws:main Sep 25, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants