-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: re-reconcile the nodeclass status #7305
fix: re-reconcile the nodeclass status #7305
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! Looks good. Just a couple comments
Pull Request Test Coverage Report for Build 11604399987Details
💛 - Coveralls |
294042e
to
e3a509a
Compare
@jmdeal @jonathan-innis hi, can u help me review again, i have resolve the comments, thank u! |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
e3a509a
to
12f3328
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
if users omit the necessary tags and later add them, we need to reprocess the information
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.