Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: scope CRD update permissions v0.34.x #7332

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Nov 6, 2024

Fixes #N/A

Description
Scopes down update CRD permissions given to Karpenter.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner November 6, 2024 18:36
@rschalo rschalo requested a review from danxwang22 November 6, 2024 18:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11709785758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 77.922%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.37%
Totals Coverage Status
Change from base Build 11569081831: -0.02%
Covered Lines: 5446
Relevant Lines: 6989

💛 - Coveralls

@rschalo rschalo enabled auto-merge (squash) November 6, 2024 23:49
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 6990998 into aws:release-v0.34.x Nov 6, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants