Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: Enable Node Repair for the E2E testing #7408

Merged
merged 1 commit into from
Nov 19, 2024
Merged

ci: Enable Node Repair for the E2E testing #7408

merged 1 commit into from
Nov 19, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 19, 2024 •
edited
Loading

Fixes #N/A

Description

  • Enable node repair for our E2E testing

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner November 19, 2024 16:38
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b3f688a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673cbf031971750008c998eb

@engedaam engedaam enabled auto-merge (squash) November 19, 2024 16:39
jonathan-innis
jonathan-innis approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 809c2f1 into aws:main Nov 19, 2024
17 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11917585971

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.329%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11917537970: -0.03%
Covered Lines: 5684
Relevant Lines: 6904
💛 - Coveralls

edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
@engedaam @edibble21
ci: Enable Node Repair for the E2E testing (aws#7408)
fb8e0ce
@engedaam engedaam deleted the enable-noderepair-e2e branch January 10, 2025 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis