Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: only tag owned resources #7446

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 26, 2024

Fixes #N/A

Description
Adds a management check to the tagging controller.

How was this change tested?
integration testing

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 26, 2024 16:10
@jmdeal jmdeal requested a review from rschalo November 26, 2024 16:10
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit c510805
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6745f2f2ff52f10007a15c93
😎 Deploy Preview https://deploy-preview-7446--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12034594342

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 65.126%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/controllers/nodeclaim/tagging/controller.go 2 3 66.67%
Totals Coverage Status
Change from base Build 12025645916: 0.004%
Covered Lines: 5733
Relevant Lines: 8803

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit b27b621 into aws:main Nov 26, 2024
17 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants