Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Docs: Added note to migration guide for expiration causing more pods in sch… #7474

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Docs: Added note to migration guide for expiration causing more pods in sch… #7474

merged 3 commits into from
Dec 4, 2024

Conversation

edibble21
Copy link
Contributor

…eduling

Fixes #N/A

Description
Added note to migration guide for expiration causing more pods in scheduling
How was this change tested?
make website
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner December 2, 2024 19:08
@edibble21 edibble21 requested a review from danxwang22 December 2, 2024 19:08
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 71ac222
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6750a1848e64a800080e55b1
😎 Deploy Preview https://deploy-preview-7474--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12166204016

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%
Totals Coverage Status
Change from base Build 12147487832: 0.0%
Covered Lines: 5733
Relevant Lines: 8817
💛 - Coveralls

jmdeal
jmdeal approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 enabled auto-merge (squash) December 4, 2024 18:39
@edibble21 edibble21 merged commit 1c94cfd into aws:main Dec 4, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edibble21 @coveralls @jmdeal