Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: added a test where there is no ips #7549

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Summonair
Copy link

@Summonair Summonair commented Dec 21, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Summonair Summonair requested a review from a team as a code owner December 21, 2024 16:34
@Summonair Summonair requested a review from jigisha620 December 21, 2024 16:35
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2a80d4c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6777e094d6d4bc000849dd37

@Summonair
Copy link
Author

this pr is adding a test before merging #7310, which fixes issues #5234 , #2921
@rschalo i've added the test you asked in #7310 (comment)

@Vacant2333
Copy link
Contributor

thank u for this!
/assign

Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
this looks good to me,thanks!

@Summonair
Copy link
Author

@jigisha620 Hey, when you get a chance, it would mean a lot if you could take a quick look at this PR. I know you’re busy, but your feedback would be really valuable to us (me and @Vacant2333)

@Vacant2333
Copy link
Contributor

@rschalo hi, can u help us to review this pr? its really important for the issue #5234

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants