fix: Linkify skips double square brackets for text #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update: version to v4.22.1
Jurredr
approved these changes
Feb 3, 2025
dogusata
deleted the
dogusata/fix-linkify-skips-double-square-bracket-texts
branch
This was referenced Feb 3, 2025
justinmk3
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Feb 3, 2025
## Problem - The citation links are broken after the [linkify structure change](#6449). ## Solution - Updated link check pattern to accept `[[TEXT]](LINK)` format too which is used for citations. **[MynahUI v4.22.1](https://github.com/aws/mynah-ui/releases/tag/v4.22.1)** [MynahUI PR](aws/mynah-ui#228)
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem - The citation links are broken after the [linkify structure change](aws#6449). ## Solution - Updated link check pattern to accept `[[TEXT]](LINK)` format too which is used for citations. **[MynahUI v4.22.1](https://github.com/aws/mynah-ui/releases/tag/v4.22.1)** [MynahUI PR](aws/mynah-ui#228)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The latest linkify handler fix introduced a bug which the citations are not visible as clickable numbered links
Solution
Updated the pattern which checks the links are valid to also accept
[[1]](LINK)format which Q returns as this. (Double square brackets)Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.