Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci(duvet): add version input to duvet action #2452

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Jan 22, 2025

Release Summary:

Description of changes:

s2n-tls uses the s2n-quic duvet github action, and the latest update to duvet broke our CI. We need to pin to an older version of duvet.

This PR adds an input to the action so that s2n-tls can set a specific version of duvet.

Testing:

I can minimally prove that this doesn't break anything, because the ci / compliance check succeeded.
I manually tested that it actually sets the version by opening a separate PR with the s2n-quic compliance job duvet version changed to 0.3.0. The job used that version:

Installing duvet with cargo
...
Cache restored successfully
Using cached `duvet` with version 0.3.0

Compare that to this PR, where 0.4.1 is used:

Installing duvet with cargo
Installing "duvet = 0.4.1"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lrstewart lrstewart marked this pull request as ready for review January 22, 2025 23:56
@lrstewart lrstewart merged commit 30df183 into main Jan 22, 2025
129 checks passed
@lrstewart lrstewart deleted the lrstewart_duvet branch January 22, 2025 23:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants