Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Part of #1447
Description of changes:
This change enables the upload of corpus files generated from fuzz tests to an S3 bucket and allows downloading them to start a new fuzz test using the accumulated corpus files.
A new environment variable,
CORPUS_UPLOAD_LOC
, has been introduced. When this variable is specified, the fuzz test will download corpus files from the specified S3 bucket for a new fuzz test. After the test, any newly generated corpus files are uploaded to the corresponding S3 location, allowing continuous improvement of the corpus.Not a change in this PR, but new policy
s2n-tls-fuzz-corpus-s3-access
is attached to corresponding CodeBuild project to grant access to S3 bucket storing corpus files.Call-outs:
This feature can be turned on or off by specifying
CORPUS_UPLOAD_LOC
in the CodeBuild configuration by overriding the environment variable. I suggest first turning it on for s2nFuzzScheduled (a daily job that runs a single fuzz test for ~8 hours) to ensure long-term viability. Afterward, we can enable it for s2nFuzzBatch, which runs against each PR.There are also some other tasks left to do after this change:
Testing:
I have some test runs for both s2nFuzzBatch and s2nFuzzScheduled using this PR as source. You can see their build log:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.