Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add back serialization for automatic speech recognition #4586

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

samruds
Copy link
Collaborator

@samruds samruds commented Apr 16, 2024

Issue #, if available:

Description of changes:

Add back automatic speech recognition task serialization (This feature is in BETA). Ensure latest version of transformers is picked in transformers builder. This allows the latest whisper models to be detected.

E.g.
Detected 763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-inference:2.1.0-transformers4.37.0-cpu-py310-ubuntu22.04. Proceeding with the the deployment.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samruds samruds force-pushed the oncall-asr branch 2 times, most recently from 51ea253 to a1c4843 Compare April 16, 2024 21:45
@samruds samruds changed the title Oncall asr Add back serialization for automatic speech recognition Apr 16, 2024
@samruds samruds marked this pull request as ready for review April 16, 2024 22:38
@samruds samruds requested a review from a team as a code owner April 16, 2024 22:38
@samruds samruds requested review from nargokul and removed request for a team April 16, 2024 22:38
@samruds samruds requested review from makungaj1 and removed request for nargokul April 16, 2024 22:39
@samruds samruds requested a review from knikure April 16, 2024 23:05
@samruds samruds changed the title Add back serialization for automatic speech recognition fix: Add back serialization for automatic speech recognition Apr 16, 2024
@knikure knikure self-assigned this Apr 17, 2024
@knikure knikure merged commit 7b211fe into aws:master Apr 17, 2024
9 checks passed
@samruds samruds deleted the oncall-asr branch April 17, 2024 18:49
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
* Add back serialization for automatic speech recognition

* Separate out integ test

* Fix formatting

* Update model
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
* Add back serialization for automatic speech recognition

* Separate out integ test

* Fix formatting

* Update model
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants