SageMaker @remote function: Added multi-node functionality #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopistone
had a problem deploying
to
manual-approval
GitHub Actions
Error
brunopistone
had a problem deploying
to
manual-approval
GitHub Actions
Error
brunopistone
had a problem deploying
to
manual-approval
GitHub Actions
Error
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Jan 16, 2025
| @@ -91,7 +91,7 @@ def remote( | |||
| use_spot_instances=False, | |||
| max_wait_time_in_seconds=None, | |||
| use_torchrun=False, | |||
| nproc_per_node=1, | |||
| nproc_per_node: Optional[int] = None, | |||
There was a problem hiding this comment.
What does nproc stand for ? Can we use the unabbreviated string for the parameter ?
Comment on lines
+358
to
+375
| except OSError: | ||
| logger.info("No Neurons detected (normal if no neurons installed)") | ||
| return 0 | ||
| except subprocess.CalledProcessError as e: | ||
| if e.output is not None: | ||
| try: | ||
| msg = e.output.decode("utf-8").partition("error=")[2] | ||
| logger.info( | ||
| "No Neurons detected (normal if no neurons installed). \ | ||
| If neuron installed then %s", | ||
| msg, | ||
| ) | ||
| except AttributeError: | ||
| logger.info("No Neurons detected (normal if no neurons installed)") | ||
| else: | ||
| logger.info("No Neurons detected (normal if no neurons installed)") | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
Can we add unit tests for these ?
Or this file in general in a separate test file ?
There was a problem hiding this comment.
Added 3 unit tests for the environment bootstrap:
- single instance with CPU
- single instance with multi GPUs
- multiple instances with multi GPUs
brunopistone
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
approved these changes
Jan 16, 2025
10 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Added the possibility to execute distributed SageMaker Training jobs across multiple nodes (multiple instances), by loading distributed environment variables
Testing done: Unit tests for remote_function, added 2 additional unit tests for single node and multi-node
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.