Fix error when there is no session to call _create_model_request() #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Feb 26, 2025
| @@ -653,6 +654,7 @@ def arguments(self) -> RequestType: | |||
| enable_network_isolation=self.model.enable_network_isolation, | |||
| ) | |||
| else: | |||
| self.model._init_sagemaker_session_if_does_not_exist() | |||
| request_dict = self.model.sagemaker_session._create_model_request( | |||
There was a problem hiding this comment.
Do we need to include the
instance_type
parameter here ?
There was a problem hiding this comment.
these workflow step won't be run on local mode, so the instance type can be set as default to None here
pintaoz-aws
force-pushed
the
fix_none_session
branch
from
9d5b059 to
7a8cd34
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
chad119
approved these changes
Mar 3, 2025
mollyheamazon
pushed a commit
to mollyheamazon/sagemaker-python-sdk
that referenced
this pull request
Mar 14, 2025
…ws#5062) * Fix error when there is no session to call _create_model_request() * Fix codestyle --------- Co-authored-by: pintaoz <pintaoz@amazon.com>
evakravi
pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2025
…ws#5062) * Fix error when there is no session to call _create_model_request() * Fix codestyle --------- Co-authored-by: pintaoz <pintaoz@amazon.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2993
Description of changes:
Initiated a session for the model before
CreateModelSteptries to call_create_model_request()Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.