Change DefaultCWMetricsPublisher log level to debug #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big +1 on this. We worked around it by setting the log level for the |
|
This apparently shipped in https://github.com/awslabs/amazon-kinesis-client#release-162-march-23-2016 @manango can you close or merge this PR please? Its confusing to leave open. |
|
Thanks szesch for providing the fix. This change has been incorporated into 1.6.2 release. Closing the PR. |
ychunxue
pushed a commit
to ychunxue/amazon-kinesis-client
that referenced
this pull request
Jul 9, 2020
…s#49) Co-authored-by: Joshua Kim <kimjos@amazon.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a KCL application that consumes from many shards, output from DefaultCWMetricsPublisher will often log too much unnecessary information. This makes reading log files a bit of a headache and it wastes bytes when shipping log files to downstream log collectors.