Added Timeouts for DynamoDB and Kinesis Calls #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a timeout to prevent an issue where the Kinesis or DynamoDB call never completes. For Kinesis call to GetRecords the timeout defaults to 30 seconds, and can be configured on the PollingConfig. For DynamoDB and Kinesis (when calling ListShards) the timeout defaults to 60 seconds and can be configured on LeaseManagementConfig.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Mar 18, 2019
Milestone#30: https://github.com/awslabs/amazon-kinesis-client/milestone/30 * Added a message to recommend using `KinesisClientUtil` when an acquire timeout occurs in the `FanOutRecordsPublisher`. * PR#514: awslabs#514 * Added a sleep between retries while waiting for a newly created stream consumer to become active. * PR#506: awslabs#506 * Added timeouts on all futures returned from the DynamoDB and Kinesis clients. The timeouts can be configured by setting `LeaseManagementConfig#requestTimeout(Duration)` for DynamoDB, and `PollingConfig#kinesisRequestTimeout(Duration)` for Kinesis. * PR#518: awslabs#518 * Upgraded to SDK version 2.5.10. * PR#518: awslabs#518 * Artifacts for the Amazon Kinesis Client for Java are now signed by a new GPG key: pub 4096R/86368934 2019-02-14 [expires: 2020-02-14] uid Amazon Kinesis Tools <amazon-kinesis-tools@amazon.com>
sahilpalvia
pushed a commit
that referenced
this pull request
Mar 18, 2019
Milestone#30: https://github.com/awslabs/amazon-kinesis-client/milestone/30 * Added a message to recommend using `KinesisClientUtil` when an acquire timeout occurs in the `FanOutRecordsPublisher`. * PR#514: #514 * Added a sleep between retries while waiting for a newly created stream consumer to become active. * PR#506: #506 * Added timeouts on all futures returned from the DynamoDB and Kinesis clients. The timeouts can be configured by setting `LeaseManagementConfig#requestTimeout(Duration)` for DynamoDB, and `PollingConfig#kinesisRequestTimeout(Duration)` for Kinesis. * PR#518: #518 * Upgraded to SDK version 2.5.10. * PR#518: #518 * Artifacts for the Amazon Kinesis Client for Java are now signed by a new GPG key: pub 4096R/86368934 2019-02-14 [expires: 2020-02-14] uid Amazon Kinesis Tools <amazon-kinesis-tools@amazon.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added timeouts for Kinesis and DynamoDB calls
Added a timeout to prevent an issue where the Kinesis or DynamoDB call
never completes.
For Kinesis call to GetRecords the timeout defaults to 30 seconds, and can be configured
on the PollingConfig.
For DynamoDB and Kinesis (when calling ListShards) the timeout
defaults to 60 seconds and can be configured on LeaseManagementConfig.
Updated AWS Java SDK to 2.5.10.
Advance version to 2.1.3-SNAPSHOT
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.