Http Client benchmark #388
Conversation
|
This pull request introduces 1 alert when merging 4cd7338 into f81ee94 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging f445de0 into f81ee94 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging f86a9f7 into f81ee94 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ca0c7c5 into f81ee94 - view on LGTM.com new alerts:
|
| @@ -1762,6 +1767,8 @@ static void s_handler_installed(struct aws_channel_handler *handler, struct aws_ | |||
| aws_linked_list_push_back( | |||
| &connection->thread_data.outgoing_frames_queue, &connection_window_update_frame->node); | |||
| connection->thread_data.window_size_self += initial_window_update_size; | |||
| /* For automatic window management, we only update connectio windows when it droped blow 50% of MAX. */ | |||
| connection->thread_data.window_size_self_dropped_threshold = AWS_H2_WINDOW_UPDATE_MAX / 2; | |||
There was a problem hiding this comment.
nit: pull this magic number into a constant?
There was a problem hiding this comment.
it's derive from a constant... and it's more clear about where it comes from/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 79.40% 79.38% -0.02%
==========================================
Files 27 27
Lines 11685 11698 +13
==========================================
+ Hits 9279 9287 +8
- Misses 2406 2411 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -408,12 +408,6 @@ static int s_localhost_integ_h2_upload_stress(struct aws_allocator *allocator, v | |||
| s_tester.alloc = allocator; | |||
|
|
|||
| size_t length = 2500000000UL; | |||
| #ifdef AWS_OS_LINUX | |||
There was a problem hiding this comment.
remove this, since it seems to be the flow control window issue.
- we sent out too much
- the initial window from the local server is small (default to the magic 65535). https://httpwg.org/specs/rfc7540.html#iana-settings
- The local server code also update the window as data received.
Don't know why it matters that much for linux comparing to the other platform. (I think we do found this windowing issue affect linux more as well from the canary before, which matches this)
AWS_BUILD_CANARY=ONcmake flagcd build/bin/canary && ./canaryISSUE FOUND & FIXED
We update the window for connection for each data frame received, which really slows us down for frequent small chunk of data frames receiving.
Providing tiny increments to flow control in WINDOW_UPDATE frames can cause a sender to generate a large number of DATA frames. from here
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.