Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Supprt response_first_byte_timeout_ms in ConnectionManagerOptions #505

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Mar 10, 2025

Issue #, if available:

Description of changes:
We need to bind this value to Java; however, Java only supports the HttpConnectionManager. So add this value as an option to ConnectionManager as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (23f62ee) to head (0ca8258).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   79.33%   79.41%   +0.08%     
==========================================
  Files          27       27              
  Lines       11619    11621       +2     
==========================================
+ Hits         9218     9229      +11     
+ Misses       2401     2392       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waahm7 waahm7 merged commit 60c43f8 into main Mar 11, 2025
40 checks passed
@waahm7 waahm7 deleted the support-timeout-connection-manager branch March 11, 2025 14:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants