Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add network interface name validation api #675

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Sep 18, 2024

Description of changes:

  • We want to catch typos in network interface names at S3Client initialization. While it will not catch all issues, like a network interface failing to connect to S3, it will still be helpful in catching invalid names.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (dc41ddc) to head (32675ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   80.39%   80.40%           
=======================================
  Files          28       28           
  Lines        5992     5995    +3     
=======================================
+ Hits         4817     4820    +3     
  Misses       1175     1175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 enabled auto-merge (squash) October 16, 2024 15:40
@waahm7 waahm7 merged commit e363740 into main Oct 16, 2024
39 checks passed
@waahm7 waahm7 deleted the validate-interface-name-helper-api branch October 16, 2024 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants