Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(requestv2): fixes multiton/singleton header parsing (#178) #179

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

hohmannr
Copy link
Contributor

@hohmannr hohmannr commented May 22, 2023

Issue #178

Description of changes:

  • added single-value (singleton) and multi-value-capable (multiton) header split to requestv2.go
  • adapted header fields parsing according to singleton/multiton differentiation
  • added tests (Disclaimer: first time using ginkgo, hope this is fine)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sapessi sapessi merged commit 429835c into awslabs:master Sep 22, 2023
@hohmannr hohmannr deleted the fix/singleton-header-splitting branch October 8, 2023 15:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants