test: use dummy credential when executing tests #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroaki Goto <hiroag@amazon.com>
StoneDot
force-pushed
the
cargo-test-with-default-cred
branch
from
1b413e1 to
a4f9b7c
Compare
ryota-sakamoto
approved these changes
Nov 29, 2024
kzym-w
pushed a commit
to kzym-w/dynein
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Hiroaki Goto <hiroag@amazon.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Currently, the
cargo testcommand uses a default credential chain to determine an AWS credential. However, it should use a dummy credential instead because an actual credential may change the production environment. Switching the default credential to a dummy credential also mitigates the pain when executing acargo testthat may require settingAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEY.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.