Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update clap to v4 #81

Merged
merged 1 commit into from
May 23, 2024
Merged

Update clap to v4 #81

merged 1 commit into from
May 23, 2024

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented May 21, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@rejao rejao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rejao rejao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bump the package version

@kdnakt
Copy link
Contributor Author

kdnakt commented May 23, 2024

Can you please bump the package version

Sure!
Before modifying the Cargo.toml file, please allow me to confirm two points:

  1. Should the next version be 0.3.3, or would 0.4.0 be more appropriate?
  2. Should I add this information to the CHANGELOG.md? I couldn't determine if it qualifies as notable changes.

@vche
Copy link
Contributor

vche commented May 23, 2024

Thanks ! But don't bother. We have another pending merge, so we have updated the revision there. We're merging this now and will publish a new releast in cargo today :)

@vche vche merged commit 9a10212 into awslabs:master May 23, 2024
1 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants