[Performance] NCCL workaround #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classicsong
reviewed
Aug 21, 2023
Merged
classicsong
reviewed
Aug 21, 2023
added 2 commits
August 21, 2023 22:14
classicsong
added a commit
that referenced
this pull request
Aug 24, 2023
*Issue #, if available:* *Description of changes:* Should work with #383 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: Xiang Song <xiangsx@amazon.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a workaround of Issue #87
NCCL backend is not supported for utilizing learnable embeddings on nodes. It has a dependency on distDGL (PR dmlc/dgl#5929). This PR removes the dependency by suggesting gloo backed for those cases.