Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[GSProcessing] Add default argument values for optional numerical transformation kwargs #944

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

thvasilo
Copy link
Contributor

Also adds tests and fixes some pylint errors in test file.

Issue #, if available:

Description of changes:

  • Previously if a user provided a numerical transformation config where imputer, norm, or separator (for multi-num) was missing, the job would fail since the object could not be instantiated without all required arguments, although we list those args as optional.
  • This PR adds default values for all optional args in the classes' init
  • Also adds a couple of tests and fixes a few pylint errors in the test file.
  • Also add a test for the case where the multi-numerical input is a vector value (which is the case for Parquet vector inputs)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…nsformation kwargs

Also adds tests and fixes some pylint errors in test file.
@thvasilo thvasilo added ready able to trigger the CI gsprocessing For issues and PRs related the the GSProcessing library 0.3.1 labels Jul 30, 2024
@thvasilo thvasilo added this to the 0.3.1 milestone Jul 30, 2024
@thvasilo thvasilo requested a review from jalencato July 30, 2024 00:15
@thvasilo thvasilo self-assigned this Jul 30, 2024
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo merged commit d728429 into awslabs:main Aug 5, 2024
9 checks passed
@thvasilo thvasilo deleted the gsp-numerical-default-args branch August 5, 2024 23:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
0.3.1 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants