Support alternative partitions in e2e tests #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
temporarily deployed
to
approval-gate
GitHub Actions
Inactive
yerzhan7
reviewed
Feb 21, 2025
Comment on lines
-36
to
+39
| iamPolicyS3FullAccess = "arn:aws:iam::aws:policy/AmazonS3FullAccess" | ||
| iamPolicyS3ReadOnlyAccess = "arn:aws:iam::aws:policy/AmazonS3ReadOnlyAccess" | ||
| iamPolicyS3NoAccess = "arn:aws:iam::aws:policy/AmazonEC2ReadOnlyAccess" // `AmazonEC2ReadOnlyAccess` gives no S3 access | ||
| iamPolicyS3FullAccess = "AmazonS3FullAccess" | ||
| iamPolicyS3ReadOnlyAccess = "AmazonS3ReadOnlyAccess" | ||
| iamPolicyS3NoAccess = "AmazonEC2ReadOnlyAccess" // `AmazonEC2ReadOnlyAccess` gives no S3 access |
There was a problem hiding this comment.
There is also partition hardcoded in this file: https://github.com/awslabs/mountpoint-s3-csi-driver/blob/main/tests/e2e-kubernetes/scripts/eksctl-patch.json
Do we need to adjust it too?
There was a problem hiding this comment.
Possibly - I can't remember how I created my test China cluster
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Removes hard-coded
awspartition, and uses sts getCallerIdentity to retrieve an ARN which can be used to extract the current partition. Additionally, replaces busybox from dockerhub with busybox from ecr public.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.