Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/support where filter #176

Merged

Conversation

andreimek
Copy link
Contributor

@andreimek andreimek commented Dec 4, 2023

Issue #, if available:
158
Description of changes:
Added support for the .where method, which in Scala is implemented in the CheckWithLastConstranitFilterable class. The idea is to check that the _Check attribute is an instance of this class and only then allow the .where method to be applied.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@chenliu0831 chenliu0831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

tests/test_checks.py Show resolved Hide resolved
pydeequ/checks.py Outdated Show resolved Hide resolved
chenliu0831
chenliu0831 previously approved these changes Dec 5, 2023
Copy link
Contributor

@chenliu0831 chenliu0831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@chenliu0831 chenliu0831 merged commit 0c0e1e4 into awslabs:master Dec 6, 2023
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants