chore: update to list_objects_v2 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two Amazon Code Guru items: - The API method `list_objects` returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: `IsTruncated`, `Marker`, `NextMarker`, `NextToken`. [Learn more](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/paginators.html) - This code uses an outdated API. [list_objects_v2 is the revised List Objects API, and we recommend you use this revised API for new application developments](https://docs.aws.amazon.com/AmazonS3/latest/API/v2-RESTBucketGET.html).
ravij3
approved these changes
Feb 21, 2023
scheurik
pushed a commit
that referenced
this pull request
Jun 14, 2024
This addresses two Amazon Code Guru items: - The API method `list_objects` returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: `IsTruncated`, `Marker`, `NextMarker`, `NextToken`. [Learn more](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/paginators.html) - This code uses an outdated API. [list_objects_v2 is the revised List Objects API, and we recommend you use this revised API for new application developments](https://docs.aws.amazon.com/AmazonS3/latest/API/v2-RESTBucketGET.html).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This addresses two Amazon Code Guru items:
list_objectsreturns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned:IsTruncated,Marker,NextMarker,NextToken. Learn moreBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.