fix: updated the workflow editor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the list of pipelines so that it always renders the way users expect
ravij3
approved these changes
May 19, 2023
scheurik
pushed a commit
that referenced
this pull request
Jun 14, 2024
* fix: updated the workflow editor to be a functional transformation of the list of pipelines so that it always renders the way users expect
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous workflow editor was very driven by side-effects which made it difficult to reason about what it was doing. This new version simplifies the workload by making the React Flow element set a transformation of the set of pipelines passed into the workflow editor. This also fixes a problem with the initial state of the editor not having all the expected components rendered without clicking the add pipeline button.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.