This repository was archived by the owner on Feb 4, 2025. It is now read-only.
fix: specialised object primitive #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyOGo
commented
Mar 21, 2019
schemas/common/all-types.json
Outdated
| { "type": ["boolean", "null", "number", "string", "array"] }, | ||
| { | ||
| "type": "object", | ||
| "minProperties": 2 |
There was a problem hiding this comment.
@mjenny
@lina-salih
We should also allow object with single keys if their name isn't an operator.
storm1ng
suggested changes
Mar 21, 2019
schemas/common/any-wo-array.json
Outdated
| "$id": "http://jsonlogic.com/schemas/common/any-wo-array.json", | ||
|
|
||
| "title": "All", | ||
| "description": "Any valid JSON Logic data source.", |
There was a problem hiding this comment.
Maybe clarify that this comes without array?
There was a problem hiding this comment.
Something like Any valid JSON logic data source other than array.
storm1ng
approved these changes
Mar 21, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15
Changes:
arraytype for single arg checksanyOfwithoneOfobjecttype, if object is empty, has more than 2 keys, or single key does not match existing operator name?:alias forif