Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add cargo-auditable config option #1528

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Add cargo-auditable config option #1528

merged 12 commits into from
Nov 6, 2024

Conversation

duckinator
Copy link
Contributor

@duckinator duckinator commented Nov 5, 2024

deferred:

complete:

  • use cargo auditable build instead of cargo build if cargo-auditable=true
  • install cargo-auditable in workflows if cargo-auditable=true
  • tests for both of those
  • real-world local test
  • real-world CI test

Moved from #1516 because the duckinator/auditable-builds branch name was incompatible with testing dist from a GitHub branch.

Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized there's one mistake in the template setup - something needs to get moved.

@duckinator duckinator force-pushed the auditable-builds branch 2 times, most recently from 5fa1c10 to 6ae94be Compare November 5, 2024 22:00
@duckinator
Copy link
Contributor Author

$ cargo audit bin axolotlsay                                                                                                              
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 664 security advisories (from /home/puppy/.cargo/advisory-db)
    Updating crates.io index
       Found 'cargo auditable' data in axolotlsay (23 dependencies)

Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor, non-blocking comment. Otherwise, I think we're looking great here! The snapshot tests show the changes we'd want to see in the outputs, too.

@duckinator duckinator merged commit f1b4789 into main Nov 6, 2024
18 checks passed
@duckinator duckinator deleted the auditable-builds branch November 6, 2024 00:10
@duckinator duckinator added this to the 0.26.0 milestone Nov 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants