otel: fix multi-worker window and fetch-limit calculation #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes opentelemetry() and axosyslog-otlp() when workers() > 1, because originally init_window_size was always set to 0 (-1 / num_workers). Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Sep 25, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
fix-otlp-multiworker-iw
branch
from
58464de to
9ae0439
Compare
alltilla
approved these changes
Sep 26, 2024
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init_window_sizewas always 0 whenworkers()was set to>1, because it was placed too early in theinit()method:-1 / num_workers.