-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
grpc: add clickhouse dest #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pull Request introduces config grammar changesaxoflow/9aa7142e84e7fe4ae29c65cc922fa2f9835f2516 -> alltilla/grpc-clickhouse --- a/destination
+++ b/destination
+clickhouse(
+ auth(
+ adc(<empty>)
+ alts(
+ <empty>
+ target-service-accounts(
+ <empty>
+ <string>
+ )
+ )
+ insecure(<empty>)
+ tls(
+ <empty>
+ ca-file(<string>)
+ cert-file(<string>)
+ key-file(<string>)
+ )
+ )
+ batch-bytes(<positive-integer>)
+ batch-lines(<nonnegative-integer>)
+ batch-timeout(<positive-integer>)
+ channel-args(
+ <empty>
+ <string> => <number>
+ <string> => <string>
+ )
+ compression(<yesno>)
+ database(<string>)
+ disk-buffer(
+ capacity-bytes(<number>)
+ compaction(<yesno>)
+ dir(<string>)
+ disk-buf-size(<number>)
+ flow-control-window-bytes(<nonnegative-integer>)
+ flow-control-window-size(<nonnegative-integer>)
+ front-cache-size(<nonnegative-integer>)
+ mem-buf-length(<nonnegative-integer>)
+ mem-buf-size(<nonnegative-integer>)
+ prealloc(<yesno>)
+ qout-size(<nonnegative-integer>)
+ reliable(<yesno>)
+ truncate-size-ratio(<nonnegative-float>)
+ )
+ flags(
+ <empty>
+ <string>
+ )
+ frac-digits(<nonnegative-integer>)
+ headers(
+ <empty>
+ <string> => <template-content>
+ <string> => <template-reference>
+ )
+ hook-commands(
+ setup(<string>)
+ shutdown(<string>)
+ startup(<string>)
+ teardown(<string>)
+ )
+ internal(<yesno>)
+ keep-alive(
+ <empty>
+ max-pings-without-data(<nonnegative-integer>)
+ time(<nonnegative-integer>)
+ timeout(<nonnegative-integer>)
+ )
+ local-time-zone(<string>)
+ log-fifo-size(<positive-integer>)
+ on-error(<string>)
+ password(<string>)
+ persist-name(<string>)
+ protobuf-schema(<path> => <template-content-list>)
+ retries(<positive-integer>)
+ schema(
+ <empty>
+ <string> <string> => <template-content>
+ <string> => <template-content>
+ )
+ send-time-zone(<string>)
+ table(<string>)
+ template-escape(<yesno>)
+ throttle(<nonnegative-integer>)
+ time-reopen(<positive-integer>)
+ time-zone(<string>)
+ ts-format(<string>)
+ url(<string>)
+ user(<string>)
+ worker-partition-key(<template-content>)
+ workers(<positive-integer>)
+)
|
342617b
to
b94b2d9
Compare
rebased to main and fixed the copyright check |
alltilla
commented
Oct 24, 2024
alltilla
commented
Oct 24, 2024
b68d55d
to
e407a4b
Compare
OverOrion
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, nice!
e407a4b
to
4a604e2
Compare
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Imported from: https://github.com/ClickHouse/ClickHouse/blob/5b9f9a26071f00302fb2ee0176185d758d38d580/src/Server/grpc_protos/clickhouse_grpc.proto Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
This is needed, because these symbols collide with the ones in syslog.h. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Based on: https://github.com/ClickHouse/ClickHouse/blob/5b9f9a26071f00302fb2ee0176185d758d38d580/utils/grpc-client/clickhouse-grpc-client.py Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Based on: https://clickhouse.com/docs/en/sql-reference/data-types Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
4a604e2
to
04d348f
Compare
OverOrion
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice! 🚀
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example config:
table creation in clickhouse:
make sure to enable grpc in clickhouse:
For reviewers:
Depends on #338