stats: do not allow resetting Prometheus metrics #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepov
previously approved these changes
Nov 8, 2024
alltilla
previously approved these changes
Nov 8, 2024
AxoSyslog now has a lot of gauge metrics, which should not be reset. Instead of implementing metric typing support and filtering based on that, this patch disallows the reset mechanism for all new metrics, since resetting anything sent to Prometheus does not make sense. Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
do-not-reset-new-metrics
branch
from
f09d0a2 to
585bcf8
Compare
alltilla
previously approved these changes
Nov 8, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
alltilla
approved these changes
Nov 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AxoSyslog now has a lot of gauge metrics, which should not be reset. Instead of implementing metric typing support and filtering based on that, this patch disallows the reset mechanism for all new metrics, since resetting anything sent to Prometheus does not make sense.
(The patch keeps the original behavior for legacy stats counters.)